Regression for gdb.fortran/library-module.exp [Re: [RFA] choose symbol from given block's objfile first.]

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

On Wed, 09 May 2012 21:05:29 +0200, Joel Brobecker wrote:
> gdb/ChangeLog:
> 
>         * findvar.c (default_read_var_value): For LOC_UNRESOLVED symbols,
>         try locating the symbol in the symbol's own objfile first, before
>         extending the search to all objfiles.
>         * symtab.c (lookup_symbol_aux_objfile): New function, extracted
>         out of lookup_symbol_aux_symtabs.
>         (lookup_symbol_aux_symtabs): Add new parameter "exclude_objfile".
>         Replace extracted-out code by call to lookup_symbol_aux_objfile.
>         Do not search EXCLUDE_OBJFILE.
>         (lookup_static_symbol_aux): Update call to lookup_symbol_aux_symtabs.
>         (lookup_symbol_global): Search for matches in the block's objfile
>         first, before searching all other objfiles.
> 
> gdb/testsuite/ChangeLog:
> 
>         * gdb.base/ctxobj-f.c, gdb.base/ctxobj-m.c, gdb.base/ctxobj-v.c,
>         gdb.base/ctxobj.exp: New files.
> 
> Tested on x86_64-linux.  No regression.

I have different opinion.

 Running gdb/testsuite/gdb.fortran/library-module.exp ...
 PASS: gdb.fortran/library-module.exp: continue to breakpoint: i-is-2-in-lib
-PASS: gdb.fortran/library-module.exp: print var_i in lib
+FAIL: gdb.fortran/library-module.exp: print var_i in lib
 PASS: gdb.fortran/library-module.exp: continue to breakpoint: i-is-2-in-main
-PASS: gdb.fortran/library-module.exp: print var_i in main
+FAIL: gdb.fortran/library-module.exp: print var_i in main
 PASS: gdb.fortran/library-module.exp: print var_j
 PASS: gdb.fortran/library-module.exp: print var_k

439e2afe4a00ff5f7c07ac033208207e095b1708 is the first bad commit
commit 439e2afe4a00ff5f7c07ac033208207e095b1708
Author: Joel Brobecker <brobecker@gnat.com>
Date:   Thu May 10 16:24:38 2012 +0000

    Search global symbols from the expression's block objfile first.


Regards,
Jan