This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Microblaze simulator - Fix missing prototype


On 05/08/2012 12:21 AM, Sergio Durigan Junior wrote:
Hi Joel,

Same comment from last e-mail: please send the patches to
gdb-patches@sourceware.org.  I am replying this e-mail to the
appropriate list, with comments about your patch, but please send other
patches to that list.

On Monday, May 07 2012, Joel Sherrill wrote:

Without this patch, this generates a missing prototype
warning which is treated as an error. I don't see this
routine referenced elsewhere, so there is the possibility
that it also could be made static.
The `_initialize*' routines are treated specially by the Makefile, when
you build the project.  They cannot be made static because they are
called from another source file.  Take a look at gdb/Makefile.in, and
search for the rule `init.c:'.
I suspected that and figured it was special given the odd name.
OK to apply?
Small nit below.

Index: gdb/microblaze-rom.c
===================================================================
RCS file: /cvs/src/src/gdb/microblaze-rom.c,v
retrieving revision 1.5
diff -u -r1.5 microblaze-rom.c
--- gdb/microblaze-rom.c	4 Jan 2012 08:17:06 -0000	1.5
+++ gdb/microblaze-rom.c	7 May 2012 20:15:54 -0000
@@ -25,6 +25,8 @@
  #include "serial.h"
  #include "regcache.h"

+void _initialize_picobug_rom(void);
There should be a space between the function name and the open paren.
OK. I changed that.

I am not a maintainer, but this change seems pretty trivial to me so that it can be committed without an explicit approval.
I thought so but always feel better getting other opinions. Better
to be cautious than reverted.

Committed
Thanks,



--
Joel Sherrill, Ph.D.             Director of Research&   Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
    Support Available             (256) 722-9985



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]