Re: [PATCH 01/20] Multi-process + multiarch: GDB

[Yao Qi <yao at codesourcery dot com>]

On 04/11/2012 07:47 AM, Pedro Alves wrote:
> +  /* Setup the inferior's initial arch, based on information obtained
> +     from the global "set ..." options.  */
> +  gdbarch_info_init (&info);
> +  gdbarch_info_fill (&info);
> +  inf->gdbarch = gdbarch_find_by_info (info);

gdbarch_info_fill is called in gdbarch_find_by_info, so we don't need
call gdbarch_info_fill here.

> +  /* The "set ..." options reject invalid settings, so we should
> +     always have a valid arch by now.  */
> +  gdb_assert (inf->gdbarch != NULL);
> +
>    return inf;
>  }

> diff --git a/gdb/testsuite/gdb.multi/multi-arch.exp b/gdb/testsuite/gdb.multi/multi-arch.exp
> new file mode 100644
> index 0000000..5f9d468
> --- /dev/null
> +++ b/gdb/testsuite/gdb.multi/multi-arch.exp

> +
> +if [istarget "s390*-*-*"] {
> +    set march1 "-m64"
> +    set march2 "-m31"
> +} else {
> +    set march1 "-m64"
> +    set march2 "-m32"
> +}

We may cover arm (-marm vs. -mthumb) and mips (mips vs. mips16) here.

-- 
Yao (éå)