This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: sparc gdbserver bug? (Re: [RFA] handle android bionic ptrace in gdbserver.)

On 03/29/2012 06:22 PM, H.J. Lu wrote:

> On Thu, Mar 29, 2012 at 10:02 AM, Pedro Alves <palves@redhat.com> wrote:


>>  #ifndef __sparc__
>>  -      res = ptrace (regset->get_request, pid, 0, buf);
>>  +      res = ptrace (regset->get_request, pid, nt_type, data);
>>  #else
>>  -      res = ptrace (regset->get_request, pid, buf, 0);
>>  +      res = ptrace (regset->get_request, pid, &iov, data);
>>  #endif
>>
>> I think that should have ended up with:
>>
>>  #ifndef __sparc__
>>       res = ptrace (regset->get_request, pid, nt_type, data);
>>  #else
>>       res = ptrace (regset->get_request, pid, data, nt_type);
>>  #endif
>>
> 
> It may be a typo for sparc branch.


Thanks.  I found a sparc-linux machine on the gcc compile farm,
and since I'm already making changes that affect all gdbserver
ports, I'll eventually run into it and fix it.

-- 
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]