This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] find_and_open_script: Fix failed fdopen
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 23 Jan 2012 16:09:17 +0000
- Subject: Re: [patch] find_and_open_script: Fix failed fdopen
- References: <20120123160309.GA25174@host2.jankratochvil.net>
On 01/23/2012 04:03 PM, Jan Kratochvil wrote:
> @@ -513,6 +513,17 @@ find_and_open_script (const char *script_file, int search_path,
> do_cleanups (old_cleanups);
>
> *streamp = fdopen (fd, FOPEN_RT);
> + if (*streamp == NULL)
> + {
> + int save_errno = errno;
> +
> + if (full_pathp)
> + xfree (*full_pathp);
> + do_cleanups (old_cleanups);
This do_cleanups doesn't look right. From the patch context, there's
already do_cleanups(old_cleanups) call a bit above.
--
Pedro Alves