This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb.ada/catch_ex.exp, gdb.ada/mi_catch_ex.exp and unsupported catchpoints


On 12/20/2011 02:51 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
> 
> Pedro> Here's a start.  I didn't really try to confirm if I was extracting the
> Pedro> arguments correctly for any other function bug the Ada runtime's
> Pedro> function in question, but at least it works in the case we're
> Pedro> interested in.  :-)
> 
> I think it looks pretty good.
> 
> If you put this in, I will look at making the next-over-throw code use
> it.

That sounds nice.  Joel wasn't very keen on it, so I'm not sure about the Ada
parts.  I've now put it at:

  https://github.com/palves/gdb/tree/build_prototype

> Pedro> +      /* The FULL_NAME pointer is at offset 8 of the object pointed by
> Pedro> +	 E.  */
> Pedro> +      full_name_val = value_at (void_ptr_type, e + 8);
> 
> 8 seems wrong on 32 bit.

It looked okay to me, as the two preceding members are 4 bytes
each, on both 32-bit and 64-bit, but ICBW.

> Now, of course, we need struct layout code... :-)

In any case, that'd be nice.  :-)

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]