This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 2/5] allow pending tracepoint


On 11/17/2011 03:03 AM, Pedro Alves wrote:
>> > Note that we don't check/validate SALs for pending fast trace point,
>> > because inferior may not be ready to access at that moment.
> Hmm, confusing comment.  You don't validate the SALs for pending
> tracepoints because a pending tracepoint has only one dummy sal,
> and it makes no sense to validate a dummy sal.
> 

Yes, the sal->pc is 0x0, and we'll get this error from GDB:

  "Cannot access memory at address 0x0"

You are right, and my description is confusing/misleading.

>> > -      struct breakpoint *b;
>> > +      struct breakpoint *b = NULL;
> Unnecessary initialization.

Removed.

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]