This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 3/8] New target hook `to_can_download_tracepoint_loc'


On Tuesday 08 November 2011 06:21:11, Yao Qi wrote:
> This patch is to add a new target hook 'to_can_download_tracepoint_loc'
> to determine whether it is OK for remote target to receive tracepoint
> locations.

Please drop the _loc from this one too.

> 0003-new-target-hook-can_download_tracepoint_loc.patch
>           * target.h (struct target): New field
>         `to_can_download_tracepoint_loc'.

Note tabs vs spaces.  The log entries should be indented with
tabs.

> +static int
> +remote_can_download_tracepoint_loc ()

(void)

> +    /* Can the target be able to download tracepoint locations in current
> +       status?  */

    Is the target able to ... in the current state

> +    int (*to_can_download_tracepoint_loc) (void);

Okay with those changes.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]