This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Python Finish Breakpoints
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Kevin Pouget <kevin dot pouget at gmail dot com>
- Cc: tromey at redhat dot com, gdb-patches at sourceware dot org
- Date: Mon, 24 Oct 2011 09:00:44 -0400
- Subject: Re: [RFC] Python Finish Breakpoints
- References: <BANLkTim+YH64zkWvdz2_kVUUj=AJ7v4LKw@mail.gmail.com> <BANLkTi=Eu-5B4YyhP2rGdQXgXbBN-EmLKA@mail.gmail.com> <BANLkTikt2hEUcXkGVH44NaUcwiF1SGdMaw@mail.gmail.com> <BANLkTi=UpgogckTD5MZsW+PC5d2F8X-+jA@mail.gmail.com> <BANLkTi==bj50mZgFKq_qA-+3-2CQA3tBVw@mail.gmail.com> <BANLkTimmYEmvKT_984jYEVZnA5RGFpEgNw@mail.gmail.com> <m34o4qd5lh.fsf@fleche.redhat.com> <BANLkTinZ3DSVPRvSiFydCuYs71-DM5-aOg@mail.gmail.com> <m3vcwvubry.fsf@fleche.redhat.com> <BANLkTinBg76_-9i5n=VA2NXp+ZF978J=ig@mail.gmail.com> <m3y5wfl7ky.fsf@fleche.redhat.com> <CAPftXUKHxpww_pEcsMruR6rqo40xw9q9Jzn65-dXys_COt6JbQ@mail.gmail.com> <CAPftXUKsSSb=36CQ+ptGenkt4Q167TtJXuDD2fkU7KFYDu_tPQ@mail.gmail.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Kevin Pouget <kevin.pouget@gmail.com>
> Date: Mon, 24 Oct 2011 11:14:42 +0200
> Cc: gdb-patches@sourceware.org
>
> I've updated the doc and testsuite accordingly, and as far as I've
> seen, there is no regression on X86_64/Fedora
> (I need still need to improve my test environment)
Thanks.
> +@subsubsection Finish Breakpoints
> +
> +@cindex python finish breakpoints
> +@tindex gdb.FinishBreakpoint
No @node? Why not?
> +extends @code{gdb.Breakpoint}. The underlying breakpoint will be disabled
^^^^^^^^^^
A typo.
> +and deleted when the execution will run out of the breakoint scope (i.e.@:
^^^^^^^^^
Another one.
> +breakpoint to become invisible to the user. @xref{Breakpoints In Python}
> +for further details about this argument.
You need a comma after the braces (didn't "make info" bitch at you?).
> +In some circonstances (e.g.@: @code{longjmp}, C++ exceptions, @value{GDBN}
^^^^^^^^^^^^^
A typo. Also, we use "C@{++}" throughout the document, it looks
prettier in print.
> +@code{return} command, ...), a function may not properly terminate, and thus
^^^
Please use @dots{} here instead of literal dots.
> +was not computable. This attribute is not writable.
Two blanks, please.
Okay with these changes.