This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] fetch result of locdesc expressions as integer (not address)


> It seems the problem is a bit more complex: different callers
> of decode_locdesc have different expectations.  As the comment
> before the routine says:
> 
>    NOTE drow/2003-11-18: This function is called in two situations
>    now: for the address of static or global variables (partial symbols
>    only) and for offsets into structures which are expected to be
>    (more or less) constant.

That's true, but my interpretation was the callers of decode_locdesc
should know which they expect it to me, and thus know to apply
the integer_to_address correction.

> Maybe we ought to have two routines (or a parameter) here.

I think this is a good idea.  But that's a bit beyond this patch.
We could add an extra routine, and implement the two using
a parameter. And then slowly transition all the callers that
read this as an address to use the new one.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]