This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Environment variables passed to inferior for Cygwin build ( follow up on mingw fix for PR 10989)
- From: Corinna Vinschen <vinschen at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 4 Oct 2011 13:15:37 +0200
- Subject: Re: [RFC] Environment variables passed to inferior for Cygwin build ( follow up on mingw fix for PR 10989)
- References: <E1R2jDx-00035B-Fq@fencepost.gnu.org> <E1R5YPa-0007H0-0B@fencepost.gnu.org> <E1R7mEx-0003rs-PZ@fencepost.gnu.org> <4E7FBF9E.20000@earthlink.net> <20110926171511.GJ17681@adacore.com> <20111004075325.GB13895@calimero.vinschen.de> <004801cc827b$e752bfd0$b5f83f70$@muller@ics-cnrs.unistra.fr> <E1RB2QN-0003Qv-81@fencepost.gnu.org>
- Reply-to: gdb-patches at sourceware dot org
On Oct 4 06:40, Eli Zaretskii wrote:
> To comment on the part of what you say that I do understand: using
> SetEnvironmentVariable in this case is not TRT, because that changes
> the environment of GDB itself. By contrast, "set environment" and
> "unset environment" commands are supposed to affect only the
> environment of the inferior, without any effect on GDB itself. That
> is why I didn't use SetEnvironmentVariable in my patch.
Duh, you're right. Maybe my proposal to create the UNICODE environment
in a static function and use that in both code paths as in
http://sourceware.org/ml/gdb-patches/2011-10/msg00071.html
is acceptable?
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat