This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [python] [patch] set/show extended-prompt
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 12 Aug 2011 23:20:12 +0100
- Subject: Re: [python] [patch] set/show extended-prompt
- References: <m3liv0yol6.fsf@redhat.com> <m3r54qidn6.fsf@fleche.redhat.com>
- Reply-to: pmuldoon at redhat dot com
Tom Tromey <tromey@redhat.com> writes:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>
> Phil> This patch adds extended-prompt capabilities to GDB. In addition
> Phil> it adds a prompt substitution library. I made the extended-prompt
> Phil> lazily control the prompt_hook on setting, over controlling it
> Phil> unconditionally. The rest of the function remains the same other
> Phil> than in-Python documentation as was found in Archer.
>
> The code bits are ok.
I am going to submit another patch with Matt's suggested changes to the
escape issue. I expect this will be a formality, but I would prefer an
explicit OK with the new changes.
> This needs a NEWS entry.
Agreed I forgot about the NEWS entry (again).
> The doc/ChangeLog entry looks messed up to me.
In which way? I generated ChangeLogs with each change in texinfo mode
with add-changelog-mode and checked the reference back to the entry.
They seem correct? I am not sure what is messed-up?
Cheers,
Phil