This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Allow -data-disassemble to run with only -s option


>>>>> "John" == John Lindal <support_0384@newplanetsoftware.com> writes:

John> Since the "disassemble" command only requires the function name, I
John> figured it would be nice if -data-disassemble did not require the
John> ending address.  The attached patch makes the end address (-e option)
John> optional.  This is backward compatible, since all existing code that
John> calls -data-disassemble passes both -s and -e.

Do you have a copyright assignment in place?
If not, contact me off-list and I will get you started.

This patch needs a documentation update.

A test case would be nice.

A few minor nits.

John> +   if (!line_seen && !file_seen && !num_seen && start_seen &&
John> !end_seen)

Your mailer mangled the patch.

John> +     {
John> +       char* ignore_name;

Wrong formatting, "char *ignore_name".

John> +       CORE_ADDR ignore_low;
John> +       if (find_pc_partial_function (low, &ignore_name, &ignore_low,

Blank line between declarations and code.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]