This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC][patch] Make DCACHE_LINE runtime-settable
On Monday 25 July 2011 20:25:42, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
>
> >> +/* BLOCK_FUNC routine for dcache_free. */
> >> +
> >> +static void
> >> +free_block (struct dcache_block *block, void *param)
> >> +{
> >> + free (block);
>
> Pedro> xfree.
>
> This one is just moving code from one spot to another.
> I don't mind it if Paul wants to fix it, but I think as a rule we
> shouldn't "review the context" and make patch submitters fix nits which
> already appear in the source.
Yes, agreed. I just hadn't noticed the function was just being moved.
Paul, if you want to fix that one, it's preaproved, either as
preparatory patch, or as followup.
--
Pedro Alves