This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [0/6] breakpoints_ops for all kinds of breakpoints
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 22 Jul 2011 11:22:37 -0600
- Subject: Re: [0/6] breakpoints_ops for all kinds of breakpoints
- References: <201107221640.25105.pedro@codesourcery.com>
>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
Pedro> I did yet a bit more work on:
Pedro> <http://sourceware.org/ml/gdb-patches/2011-06/msg00374.html>
Pedro> This converts all breakpoint kinds to the breakpoint_ops
Pedro> mechanism.
Pedro> IMO, this is committable as is. WDYT?
I read through them all. I think this is a great series. Please check
it in.
I'm not particularly fond of patch #4, but I understand why you did it,
and I agree that statically initialized vtables are a pain -- I am often
grepping for all instances and hoping I haven't missed one. (I wish we
could require designated initializers for these so I could more easily
search for field names...)
I think we could make most of the vtable pointers (but not objects due
to the initialization approach) const. I think that would help clarity
a bit. I'm happy to do this after these patches go in.
Tom