This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Wed, Jul 20, 2011 at 10:04 AM, Eli Zaretskii <eliz@gnu.org> wrote: >> Date: Mon, 18 Jul 2011 23:57:25 -0700 >> From: Matt Rice <ratmice@gmail.com> >> >> this patch adds 2 commands, >> info macros LINESPEC >> info definitions MACRO > > Thanks. ?A few minor comments and a question. > >> +@cindex definition, showing a macro's > > That sounds awkward. ?Suggest "@cindex definition of a macro, showing" > instead. This actually came from the existing 'info macro'. command, I updated that. >> +@item info macros @var{linespec} >> +Show all macro definitions at the location of @var{linespec}, and describe the > > Suggest a slight rewording: > > ?Show all macro definitions that are in effect at the location > ?specified by @var{linespec}, and describe ... k. >> +@cindex definition, showing a macro's > > It's not useful to have identical index entries so close to one > another. ?I suggest to remove the second one. ahh, I see. >> +Show all definitions of the macro named @var{macro}, in the current scope, > > It might be better to say "... definitions of the named @var{macro} ...". k. > Also, what is the "scope" of a macro? to answer your question scope of a macro is all lines between #define and #undef, not extending beyond the boundry of a compilation unit. Its the wrong word though, and not what 'info definitions' does, neither was my second patch correct. because 'info definitions' looks throughout a compilation unit. Updated the docs, and the 'help' command text for 'info definitions'. I added @cindex macros, from debug info so it would be near the existing @cindex macros, user-defined
Attachment:
foo.diff
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |