This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Code cleanup: Introduce allocate_optimized_out_value


On Tue, 12 Jul 2011 23:10:02 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> this is a code cleanup.  Additionally it makes more optimized_out values lazy.
> Jan> IIRC I had some compatibility problems before with it but I no longer see any
> Jan> regressions, maybe since:
> Jan> 	[patch 1/2] Make values more lazy if possible
> Jan> 	http://sourceware.org/ml/gdb-patches/2011-01/msg00123.html
> Jan> or thanks to some other patch.
> 
> It looks ok to me.

It is true it would be definitely a bug in a code incompatible with such
change so one may rather fix that possible regression there.

Checked it in:
	http://sourceware.org/ml/gdb-cvs/2011-07/msg00124.html


Thanks for the review,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]