This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

comments formatting [Re: [patch] physname regression: Non-matching type false breakpoint]


On Sun, 05 Jun 2011 17:57:31 +0200, Mark Kettenis wrote:
> > From: Jan Kratochvil <jan.kratochvil@redhat.com>
> > +  /* The strchr check is there if any types were specified verify the single
> > +     found found parameter types really match those specified by user in COPY.
> > +     */
> 
> That lone */ looks weird.

I agree, this commonly happens, I do not know what is the right way to do with it.

 * exceeding 80 columns is forbidden: COPY.   */

 * Non-standard formatting of paragraph is not good - as the next modification
   will possibly reformat it a bit differently, creating false diffs confusing
   diff readers: by user in\n
   COPY.  */

 * I usually reword the sentence to fit the formatting better but TBH I do not
   find that a too much usefully spent time of my life.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]