This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
FYI: more const
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 18 May 2011 14:19:24 -0600
- Subject: FYI: more const
I'm checking this in on the trunk.
This makes another 'physname' field const.
Built and regtested by the buildbot.
Tom
2011-05-18 Tom Tromey <tromey@redhat.com>
* dwarf2read.c (dwarf2_add_field): Constify.
* value.c (value_static_field): Constify.
* gdbtypes.h (struct main_type) <field.field_location.physname>:
Now const.
* ax-gdb.c (gen_static_field): Constify
diff --git a/gdb/ax-gdb.c b/gdb/ax-gdb.c
index d1736e1..19c00ad 100644
--- a/gdb/ax-gdb.c
+++ b/gdb/ax-gdb.c
@@ -1549,7 +1549,7 @@ gen_static_field (struct gdbarch *gdbarch,
}
else
{
- char *phys_name = TYPE_FIELD_STATIC_PHYSNAME (type, fieldno);
+ const char *phys_name = TYPE_FIELD_STATIC_PHYSNAME (type, fieldno);
struct symbol *sym = lookup_symbol (phys_name, 0, VAR_DOMAIN, 0);
if (sym)
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 562361e..658205e 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -6542,7 +6542,7 @@ dwarf2_add_field (struct field_info *fip, struct die_info *die,
(so through at least 3.2.1) incorrectly generate
DW_TAG_variable tags. */
- char *physname;
+ const char *physname;
/* Get name of field. */
fieldname = dwarf2_name (die, cu);
@@ -6563,7 +6563,7 @@ dwarf2_add_field (struct field_info *fip, struct die_info *die,
}
/* Get physical name. */
- physname = (char *) dwarf2_physname (fieldname, die, cu);
+ physname = dwarf2_physname (fieldname, die, cu);
/* The name is already allocated along with this objfile, so we don't
need to duplicate it for the type. */
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index f771bed..60da35b 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -509,7 +509,7 @@ struct main_type
Otherwise, physname is the mangled label of the static field. */
CORE_ADDR physaddr;
- char *physname;
+ const char *physname;
}
loc;
diff --git a/gdb/value.c b/gdb/value.c
index 2a8f3fc..ccd29c8 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -2388,7 +2388,7 @@ value_static_field (struct type *type, int fieldno)
break;
case FIELD_LOC_KIND_PHYSNAME:
{
- char *phys_name = TYPE_FIELD_STATIC_PHYSNAME (type, fieldno);
+ const char *phys_name = TYPE_FIELD_STATIC_PHYSNAME (type, fieldno);
/* TYPE_FIELD_NAME (type, fieldno); */
struct symbol *sym = lookup_symbol (phys_name, 0, VAR_DOMAIN, 0);