Re: gdbindex crash: Re: Regression: Re: RFC: implement typed DWARF stack

[Tom Tromey <tromey at redhat dot com>]

Jan> The new testcase crashes with .gdb_index:
Jan> print j
Jan> ERROR: Process no longer exists
Jan> UNRESOLVED: gdb.dwarf2/typeddwarf.exp: check value of j at typeddwarf.c:29

Tom> I have a patch for this which I'm going to test, 

Appended.  I am checking this in.

Earlier I did not realize that the types from the CU are cached, and so
we can simply look them up using get_die_type_at_offset.

Tom> but first I have to look into why the buildbot did not detect this.
Tom> My guess is that the index-based tester is not working properly.

I tracked this down to a bad 'make' invocation.
It wasn't properly passing the options to set the compiler.
I verified that it works now by examining the .log files and checking
that dejagnu is invoking cc-with-index.sh.

Tom

2011-05-17  Tom Tromey  <tromey@redhat.com>

	* dwarf2read.c (dwarf2_get_die_type): Call
	get_die_type_at_offset.
	* dwarf2expr.c (dwarf_get_base_type): Handle NULL return from
	get_base_type function.

diff --git a/gdb/dwarf2expr.c b/gdb/dwarf2expr.c
index 1fe8b79..5cd33a6 100644
--- a/gdb/dwarf2expr.c
+++ b/gdb/dwarf2expr.c
@@ -447,6 +447,8 @@ dwarf_get_base_type (struct dwarf_expr_context *ctx, ULONGEST die, int size)
   if (ctx->get_base_type)
     {
       result = ctx->get_base_type (ctx, die);
+      if (result == NULL)
+	error (_("Could not find type for DW_OP_GNU_const_type"));
       if (size != 0 && TYPE_LENGTH (result) != size)
 	error (_("DW_OP_GNU_const_type has different sizes for type and data"));
     }
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 22643c5..6558bfe 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -13671,22 +13671,8 @@ struct type *
 dwarf2_get_die_type (unsigned int die_offset,
 		     struct dwarf2_per_cu_data *per_cu)
 {
-  struct dwarf2_cu *cu = per_cu->cu;
-  struct die_info *die;
-  struct type *result;
-
   dw2_setup (per_cu->objfile);
-
-  die = follow_die_offset (die_offset, &cu);
-  if (!die)
-    error (_("Dwarf Error: Cannot find DIE at 0x%x referenced in module %s"),
-	   die_offset, per_cu->cu->objfile->name);
-
-  result = get_die_type (die, cu);
-  if (result == NULL)
-    result = read_type_die_1 (die, cu);
-
-  return result;
+  return get_die_type_at_offset (die_offset, per_cu);
 }
 
 /* Follow the signature attribute ATTR in SRC_DIE.