This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
fix a few pastos in the testsuite around "untested".
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Date: Mon, 16 May 2011 14:57:42 +0100
- Subject: fix a few pastos in the testsuite around "untested".
While diffing gdb.log's between two testruns, I noticed:
UNTESTED: gdb.ada/start.exp: exec_changed.exp
grepping around pointed at a few other copy/pastos. Fixed
as below.
Tested on x86_64-linux native and remote, and checked in.
Pedro Alves
2011-05-16 Pedro Alves <pedro@codesourcery.com>
gdb/testsuite/
* gdb.ada/start.exp: Call untested with the correct test filename.
* gdb.arch/i386-bp_permanent.exp: Call untested with the correct
test filename. Make the test's binary unique.
* gdb.arch/i386-signal.exp: Call untested with the correct test
filename.
* gdb.arch/i386-size-overlap.exp: Ditto.
* gdb.arch/Makefile.in (EXECUTABLES): Update.
* gdb.base/gcore-buffer-overflow.exp: Ditto.
* gdb.cp/call-c.exp: Ditto.
* gdb.mi/mi-reverse.exp: Call untested with the correct test
filename. Make the test's binary unique.
* gdb.mi/Makefile.in (EXECUTABLES): Update.
* gdb.python/py-mi.exp: Ditto.
* gdb.python/Makefile.in (EXECUTABLES): Update.
* gdb.reverse/i386-precsave.exp: Ditto.
* gdb.reverse/i387-env-reverse.exp: Call untested with the correct
test filename.
* gdb.reverse/i387-stack-reverse.exp: Ditto.
* gdb.reverse/sigall-precsave.exp: Ditto. Make the test's binary
unique.
* gdb.reverse/sigall-reverse.exp: Call untested with the correct
test filename.
* gdb.reverse/Makefile.in (EXECUTABLES): Update.
* gdb.trace/tfile.exp: Ditto.
---
gdb/testsuite/gdb.ada/start.exp | 2 -
gdb/testsuite/gdb.arch/Makefile.in | 4 +--
gdb/testsuite/gdb.arch/i386-bp_permanent.exp | 6 ++---
gdb/testsuite/gdb.arch/i386-signal.exp | 2 -
gdb/testsuite/gdb.arch/i386-size-overlap.exp | 2 -
gdb/testsuite/gdb.base/gcore-buffer-overflow.exp | 2 -
gdb/testsuite/gdb.cp/call-c.exp | 2 -
gdb/testsuite/gdb.mi/Makefile.in | 24 ++++++++++++-----------
gdb/testsuite/gdb.mi/mi-reverse.exp | 6 ++---
gdb/testsuite/gdb.python/Makefile.in | 2 -
gdb/testsuite/gdb.python/py-mi.exp | 21 ++++++++++----------
gdb/testsuite/gdb.reverse/Makefile.in | 3 +-
gdb/testsuite/gdb.reverse/i386-precsave.exp | 6 ++---
gdb/testsuite/gdb.reverse/i387-env-reverse.exp | 2 -
gdb/testsuite/gdb.reverse/i387-stack-reverse.exp | 2 -
gdb/testsuite/gdb.reverse/sigall-precsave.exp | 8 +++----
gdb/testsuite/gdb.reverse/sigall-reverse.exp | 2 -
gdb/testsuite/gdb.trace/tfile.exp | 2 -
18 files changed, 51 insertions(+), 47 deletions(-)
Index: src/gdb/testsuite/gdb.ada/start.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.ada/start.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.ada/start.exp 2011-05-16 14:26:48.573488999 +0100
@@ -24,7 +24,7 @@ if { [skip_ada_tests] } { return -1 }
# This testcase verifies the behavior of the `start' command, which
# does not work when we use the gdb stub...
if [target_info exists use_gdb_stub] {
- untested exec_changed.exp
+ untested start.exp
return
}
Index: src/gdb/testsuite/gdb.arch/i386-bp_permanent.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.arch/i386-bp_permanent.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.arch/i386-bp_permanent.exp 2011-05-16 14:26:48.573488999 +0100
@@ -27,8 +27,8 @@ if {(![istarget "x86_64-*-*"] && ![istar
return
}
-set testfile "i386-prologue"
-set srcfile ${testfile}.c
+set testfile "i386-bp_permanent"
+set srcfile i386-prologue.c
set binfile ${objdir}/${subdir}/${testfile}
# some targets have leading underscores on assembly symbols.
@@ -41,7 +41,7 @@ if [istarget "i?86-*-cygwin*"] then {
# Don't use "debug", so that we don't have line information for the assembly
# fragments.
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list $additional_flags]] != "" } {
- untested i386-prologue.exp
+ untested ${testfile}.exp
return -1
}
Index: src/gdb/testsuite/gdb.arch/i386-signal.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.arch/i386-signal.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.arch/i386-signal.exp 2011-05-16 14:26:48.583489000 +0100
@@ -26,7 +26,7 @@ set binfile ${objdir}/${subdir}/${testfi
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
executable { debug }] != "" } {
- untested i386-sigframe.exp
+ untested ${testfile}.exp
return -1
}
Index: src/gdb/testsuite/gdb.arch/i386-size-overlap.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.arch/i386-size-overlap.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.arch/i386-size-overlap.exp 2011-05-16 14:26:48.583489000 +0100
@@ -39,7 +39,7 @@ if [istarget "i?86-*-cygwin*"] then {
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
executable [list debug $additional_flags]] != "" } {
- untested "i386-size"
+ untested ${testfile}.exp
return -1
}
Index: src/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp 2011-05-16 14:26:48.583489000 +0100
@@ -28,7 +28,7 @@ set pattern 012345678901234567890123456
set binfile ${objdir}/${subdir}/${testfile}-${pattern}
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
- untested gcore.exp
+ untested ${testfile}.exp
return -1
}
Index: src/gdb/testsuite/gdb.cp/call-c.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.cp/call-c.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.cp/call-c.exp 2011-05-16 14:26:48.583489000 +0100
@@ -30,7 +30,7 @@ set objfilecpp ${objdir}/${subdir}/${tes
if {[gdb_compile "${srcfilec}" "${objfilec}" object {debug}] != ""
|| [gdb_compile "${srcfilecpp}" "${objfilecpp}" object {c++ debug}] != ""
|| [gdb_compile "${objfilecpp} ${objfilec}" "${binfile}" executable {c++ debug}] != ""} {
- untested hang.exp
+ untested ${testfile}.exp
return -1
}
Index: src/gdb/testsuite/gdb.mi/mi-reverse.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.mi/mi-reverse.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.mi/mi-reverse.exp 2011-05-16 14:26:48.583489000 +0100
@@ -39,11 +39,11 @@ if [mi_gdb_start] {
continue
}
-set testfile "basics"
-set srcfile ${testfile}.c
+set testfile mi-reverse
+set srcfile basics.c
set binfile ${objdir}/${subdir}/mi2-reverse
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DFAKEARGV}] != "" } {
- untested mi2-reverse.exp
+ untested ${testfile}.exp
return -1
}
Index: src/gdb/testsuite/gdb.python/py-mi.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.python/py-mi.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.python/py-mi.exp 2011-05-16 14:26:48.583489000 +0100
@@ -24,11 +24,12 @@ if [mi_gdb_start] {
continue
}
-set testfile "py-prettyprint"
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/py-mi
+set testfile "py-mi"
+set srcfile py-prettyprint.c
+set binfile ${objdir}/${subdir}/${testfile}
+set pyfile py-prettyprint.py
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DMI}] != "" } {
- untested mi2-var-child.exp
+ untested ${testfile}.exp
return -1
}
@@ -43,11 +44,11 @@ if {[lsearch -exact [mi_get_features] py
mi_runto main
-set remote_python_file [remote_download host ${srcdir}/${subdir}/${testfile}.py]
+set remote_python_file [remote_download host ${srcdir}/${subdir}/${pyfile}]
mi_gdb_test "python execfile ('${remote_python_file}')" ""
-mi_continue_to_line [gdb_get_line_number {MI breakpoint here} ${testfile}.c] \
+mi_continue_to_line [gdb_get_line_number {MI breakpoint here} ${srcfile}] \
"step to breakpoint"
mi_create_dynamic_varobj container c \
@@ -221,7 +222,7 @@ mi_varobj_update_dynamic container2 \
} {} {}
mi_continue_to_line \
- [gdb_get_line_number {MI outer breakpoint here} ${testfile}.c] \
+ [gdb_get_line_number {MI outer breakpoint here} ${srcfile}] \
"step to outer breakpoint"
mi_create_dynamic_varobj outer outer \
@@ -244,14 +245,14 @@ mi_gdb_test "-var-update outer" \
"update after updating element of outer"
mi_continue_to_line \
- [gdb_get_line_number {Another MI breakpoint} ${testfile}.c] \
+ [gdb_get_line_number {Another MI breakpoint} ${srcfile}] \
"step to second breakpoint"
mi_varobj_update_with_type_change container int 0 "update after type change"
mi_continue_to_line \
- [gdb_get_line_number {break to inspect struct and union} ${testfile}.c] \
+ [gdb_get_line_number {break to inspect struct and union} ${srcfile}] \
"step to outer breakpoint"
mi_create_dynamic_varobj nscont nstype \
@@ -305,7 +306,7 @@ if {[lsearch -exact [mi_get_features] py
mi_runto main
mi_continue_to_line \
- [gdb_get_line_number {break to inspect struct and union} ${testfile}.c] \
+ [gdb_get_line_number {break to inspect struct and union} ${srcfile}] \
"step to breakpoint"
# Test python/12531. Install visualizer on a cplus_fake_child.
Index: src/gdb/testsuite/gdb.reverse/i386-precsave.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.reverse/i386-precsave.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.reverse/i386-precsave.exp 2011-05-16 14:26:48.583489000 +0100
@@ -34,8 +34,8 @@ if ![istarget "i?86-*linux*"] then {
return
}
-set testfile "i386-reverse"
-set srcfile ${testfile}.c
+set testfile "i386-precsave"
+set srcfile i386-reverse.c
set binfile ${objdir}/${subdir}/${testfile}
# some targets have leading underscores on assembly symbols.
@@ -46,7 +46,7 @@ if [istarget "i?86-*-cygwin*"] then {
}
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list debug $additional_flags]] != "" } {
- untested i386-reverse
+ untested ${testfile}.exp
return -1
}
Index: src/gdb/testsuite/gdb.reverse/i387-env-reverse.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.reverse/i387-env-reverse.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.reverse/i387-env-reverse.exp 2011-05-16 14:26:48.583489000 +0100
@@ -37,7 +37,7 @@ if [istarget "i?86-*-cygwin*"] then {
}
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list debug $additional_flags]] != "" } {
- untested i387-float-reverse
+ untested ${testfile}.exp
return -1
}
Index: src/gdb/testsuite/gdb.reverse/i387-stack-reverse.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.reverse/i387-stack-reverse.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.reverse/i387-stack-reverse.exp 2011-05-16 14:26:48.583489000 +0100
@@ -37,7 +37,7 @@ if [istarget "i?86-*-cygwin*"] then {
}
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list debug $additional_flags]] != "" } {
- untested i387-float-reverse
+ untested ${testfile}.exp
return -1
}
Index: src/gdb/testsuite/gdb.reverse/sigall-precsave.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.reverse/sigall-precsave.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.reverse/sigall-precsave.exp 2011-05-16 14:26:48.583489000 +0100
@@ -14,7 +14,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
if [target_info exists gdb,nosignals] {
- verbose "Skipping sigall-reverse.exp because of nosignals."
+ verbose "Skipping sigall-precsave.exp because of nosignals."
return
}
@@ -31,11 +31,11 @@ gdb_exit
gdb_start
gdb_reinitialize_dir $srcdir/$subdir
-set testfile sigall-reverse
-set srcfile ${testfile}.c
+set testfile sigall-precsave
+set srcfile sigall-reverse.c
set binfile ${objdir}/${subdir}/${testfile}
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
- untested sigall.exp
+ untested ${testfile}.exp
return -1
}
Index: src/gdb/testsuite/gdb.reverse/sigall-reverse.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.reverse/sigall-reverse.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.reverse/sigall-reverse.exp 2011-05-16 14:26:48.583489000 +0100
@@ -35,7 +35,7 @@ set testfile sigall-reverse
set srcfile ${testfile}.c
set binfile ${objdir}/${subdir}/${testfile}
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
- untested sigall.exp
+ untested ${testfile}.exp
return -1
}
Index: src/gdb/testsuite/gdb.trace/tfile.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.trace/tfile.exp 2011-05-16 13:59:21.383489001 +0100
+++ src/gdb/testsuite/gdb.trace/tfile.exp 2011-05-16 14:26:48.583489000 +0100
@@ -39,7 +39,7 @@ set srcfile ${testfile}.c
set binfile $objdir/$subdir/$testfile
if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
executable {debug nowarnings}] != "" } {
- untested file.exp
+ untested ${testfile}.exp
return -1
}
gdb_reinitialize_dir $srcdir/$subdir
Index: src/gdb/testsuite/gdb.arch/Makefile.in
===================================================================
--- src.orig/gdb/testsuite/gdb.arch/Makefile.in 2011-02-23 11:51:42.000000000 +0000
+++ src/gdb/testsuite/gdb.arch/Makefile.in 2011-05-16 14:43:24.433489003 +0100
@@ -2,8 +2,8 @@ VPATH = @srcdir@
srcdir = @srcdir@
EXECUTABLES = altivec-abi altivec-regs amd64-byte amd64-disp-step \
- amd64-dword amd64-i386-address amd64-word i386-permbkpt \
- i386-signal i386-sse
+ amd64-dword amd64-i386-address amd64-word i386-bp_permanent \
+ i386-permbkpt i386-avx i386-signal i386-sse
all info install-info dvi install uninstall installcheck check:
@echo "Nothing to be done for $@..."
Index: src/gdb/testsuite/gdb.mi/Makefile.in
===================================================================
--- src.orig/gdb/testsuite/gdb.mi/Makefile.in 2011-02-23 11:51:42.000000000 +0000
+++ src/gdb/testsuite/gdb.mi/Makefile.in 2011-05-16 14:45:19.793489003 +0100
@@ -1,17 +1,19 @@
VPATH = @srcdir@
srcdir = @srcdir@
-PROGS = basics c_variable cpp_variable var-cmd dw2-ref-missing-frame \
- gdb669-pthreads gdb701 gdb792 mi-async mi-basics mi-break \
- mi-cli mi-console mi-disassemble mi-eval mi-file mi-file-transfer \
- mi-non-stop mi-non-stop-exit mi-ns-stale-regcache mi-nsintrall \
- mi-nsmoribund mi-nsthrexec mi-pending mi-pthreads mi-read-memory \
- mi-regs mi-return mi-simplerun mi-stack mi-stepi mi-syn-frame \
- mi-var-block mi-var-child mi-var-cmd mi-var-cp mi-var-display \
- mi-var-invalidate mi-var-invalidate_bis mi-watch mi2-basics \
- mi2-break mi2-cli mi2-disassemble mi2-eval mi2-file mi2-pthreads \
- mi2-regs mi2-return mi2-simplerun mi2-stepi mi2-var-block \
- mi2-var-child mi2-var-cmd mi2-var-display mi2-watch until
+PROGS = basics c_variable cpp_variable var-cmd dw2-ref-missing-frame \
+ gdb669-pthreads gdb701 gdb792 mi-async mi-basics mi-break \
+ mi-cli mi-console mi-disassemble mi-eval mi-file \
+ mi-file-transfer mi-non-stop mi-non-stop-exit \
+ mi-ns-stale-regcache mi-nsintrall mi-nsmoribund mi-nsthrexec \
+ mi-pending mi-pthreads mi-read-memory mi-regs mi-return \
+ mi-reverse mi-simplerun mi-stack mi-stepi mi-syn-frame \
+ mi-var-block mi-var-child mi-var-cmd mi-var-cp mi-var-display \
+ mi-var-invalidate mi-var-invalidate_bis mi-watch mi2-basics \
+ mi2-break mi2-cli mi2-disassemble mi2-eval mi2-file \
+ mi2-pthreads mi2-regs mi2-return mi2-simplerun mi2-stepi \
+ mi2-var-block mi2-var-child mi2-var-cmd mi2-var-display \
+ mi2-watch until
MISCELLANEOUS = mi-pendshr.sl
Index: src/gdb/testsuite/gdb.python/Makefile.in
===================================================================
--- src.orig/gdb/testsuite/gdb.python/Makefile.in 2011-03-17 17:53:13.000000000 +0000
+++ src/gdb/testsuite/gdb.python/Makefile.in 2011-05-16 14:46:26.593488993 +0100
@@ -4,7 +4,7 @@ srcdir = @srcdir@
EXECUTABLES = py-type py-value py-prettyprint py-template py-block \
py-symbol py-mi py-breakpoint py-inferior py-infthread \
py-shared python lib-types py-events py-evthreads py-frame \
- py-pp-maint py-progspace py-section-script py-objfile
+ py-mi py-pp-maint py-progspace py-section-script py-objfile
MISCELLANEOUS = py-shared-sl.sl
Index: src/gdb/testsuite/gdb.reverse/Makefile.in
===================================================================
--- src.orig/gdb/testsuite/gdb.reverse/Makefile.in 2011-02-23 11:51:43.000000000 +0000
+++ src/gdb/testsuite/gdb.reverse/Makefile.in 2011-05-16 14:54:05.993488998 +0100
@@ -2,8 +2,9 @@ VPATH = @srcdir@
srcdir = @srcdir@
EXECUTABLES = break-reverse consecutive-reverse finish-reverse \
+ i386-precsave i386-reverse i386-sse-reverse \
machinestate solib-reverse step-reverse until-reverse \
- watch-reverse i386-reverse
+ watch-reverse sigall-reverse sigall-precsave
MISCELLANEOUS =