This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Fixing gdb.base/completion.exp (PR testsuite/12649)


On Mon, 02 May 2011 18:54:34 +0200, Pedro Alves wrote:
> I had looked at your new readline test, and it didn't appear
> to cover every of interesting completion variant this
> completion.exp test exercises, but I think I may have overlooked.

I believe the good enough test is that "\t" invokes GDB complete_line (via
readline_line_completion_function).  GDB complete_command also obviously leads
to complete_line.

Therefore if one tests "\t" really works in any single case (which is tested
by gdb.base/readline-ask.exp as it completes the inferior symbol names) one
can then test just the "complete" command for all the other completion
variants with the same coverage.


> If it does, then I'll agree with putting that in, and switching
> the completion.exp test to "complete" only.

But maybe the coverage equivalance is not so obvious as I considered it.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]