This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Breakpoint MI notifications
>>>>> "Volodya" == Vladimir Prus <vladimir@codesourcery.com> writes:
Volodya> Thanks for the review. Is this version better?
The full patch attachment was empty, but I read the delta and have a
couple more nits.
Volodya> +/* Returns 1 iff locations A and B are sufficiently same that
Volodya> + we don't need to report breakpoint as changed. */
Volodya> static int
There's a new rule that there should be a blank line between the comment
and function.
Volodya> + if (strncmp (parse->command, "break-", sizeof ("break-")) == parse->command)
I think the RHS has to be "0". Also, sizeof will include the trailing
\0 here, so you want `sizeof ("break-") - 1'.
Tom