This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Remove same-pc breakpoint notification for internal BPs

From: Tom Tromey <tromey at redhat dot com>
To: Pedro Alves <pedro at codesourcery dot com>
Cc: gdb-patches at sourceware dot org, Kevin Pouget <kevin dot pouget at gmail dot com>
Date: Thu, 21 Apr 2011 09:05:30 -0600
Subject: Re: [PATCH] Remove same-pc breakpoint notification for internal BPs
References: <BANLkTim4J5Nnt_bKQvcvHh+ve+jtQdkw8w@mail.gmail.com> <201104210949.18831.pedro@codesourcery.com> <m3liz3zo21.fsf@fleche.redhat.com> <201104211559.40948.pedro@codesourcery.com>

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> I never understood why we need that function (as is implemented) though.

IIRC I added it to pull common code out of a few spots, and at the same
time regularize it.  I think different spots were using slightly
different checks.

I don't object to the current patch.

Pedro> What could be !user_settable_breakpoint whose b->number is > 0?
Pedro> IOW, why isn't that just :
[...]

I don't know; I think the change to introduce the function just
commonized pre-existing code.

Tom

Follow-Ups:
- Re: [PATCH] Remove same-pc breakpoint notification for internal BPs
  - From: Pedro Alves

References:
- [PATCH] Remove same-pc breakpoint notification for internal BPs
  - From: Kevin Pouget
- Re: [PATCH] Remove same-pc breakpoint notification for internal BPs
  - From: Pedro Alves
- Re: [PATCH] Remove same-pc breakpoint notification for internal BPs
  - From: Tom Tromey
- Re: [PATCH] Remove same-pc breakpoint notification for internal BPs
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]