This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] ARI fix: Remove OP at end of line in xstormy16-tdep.c
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- Date: Tue, 19 Apr 2011 12:08:01 +0100
- Subject: Re: [RFA] ARI fix: Remove OP at end of line in xstormy16-tdep.c
- References: <006e01cbfe7e$5a8dadc0$0fa90940$@muller@ics-cnrs.unistra.fr>
On Tuesday 19 April 2011 11:41:34, Pierre Muller wrote:
> --- xstormy16-tdep.c 18 Mar 2011 18:52:32 -0000 1.114
> +++ xstormy16-tdep.c 19 Apr 2011 10:35:47 -0000
> @@ -264,11 +264,9 @@ xstormy16_push_dummy_call (struct gdbarc
> val = value_contents (args[i]);
> for (j = 0; j < typelen; j += xstormy16_reg_size)
> regcache_cooked_write_unsigned (regcache, argreg++,
> - extract_unsigned_integer (val + j,
> - typelen - j ==
> - 1 ? 1 :
> - xstormy16_reg_size,
> - byte_order));
> + extract_unsigned_integer (val + j,
> + typelen - j == 1 ? 1 :
> xstormy16_reg_size,
> + byte_order));
A sign that temporary variables would help, IMO:
for (j = 0; j < typelen; j += xstormy16_reg_size)
{
ULONGEST regval;
int size;
size = typelen - j == 1 ? 1 : xstormy16_reg_size;
val = extract_unsigned_integer (val + j, size, byte_order);
regcache_cooked_write_unsigned (regcache, argreg++, regval);
);
--
Pedro Alves