This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Lowercase static function names that use capital letters.
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- Date: Tue, 19 Apr 2011 12:02:36 +0100
- Subject: Re: [RFA] Lowercase static function names that use capital letters.
- References: <005801cbfe7a$414b24e0$c3e16ea0$@muller@ics-cnrs.unistra.fr>
On Tuesday 19 April 2011 11:12:13, Pierre Muller wrote:
> Is this patch OK or are there any valid reasons to use
> uppercase function like LM_NEXT?
I think only history, and that nobody ever bothered to lowercase
them. These started out as macros, and when the macros were
turned into real functions (when the sunos and svr4 support was
split out of solib.c, I think), the naming/casing was preserved.
> 2011-04-19 Pierre Muller <muller@ics.u-strasbg.fr>
>
> ARI fixes: Use only lowercase function name for static functions.
> * nto-tdep.c (LM_ADDR): Rename to...
> (lm_addr): New function name.
> (nto_relocate_section_addresses): Adapt to change above.
> * solib-sunos.c (LM_ADDR): Rename to...
> (lm_addr): New function name.
> (LM_NEXT): Rename to...
> (lm_next): New function name.
> (sunos_current_sos, sunos_relocate_section_addresses): Adapt to
> function name changes above.
> * solib-svr4.c (LM_ADDR_FROM_LINK_MAP): Rename to...
> (lm_addr_from_link_map): New function name.
> (HAS_LM_DYNAMIC_FROM_LINK_MAP): Rename to...
> (has_lm_dynamic_from_link_map): New function name.
> (LM_DYNAMIC_FROM_LINK_MAP): Rename to...
> (lm_dynamic_from_link_map): New function name.
> (LM_ADDR_CHECK): Rename to...
> (lm_addr_check): New function name.
> (LM_NEXT): Rename to...
> (lm_next): New function name.
> (LM_PREV): Rename to...
> (lm_prev): New function name.
> (LM_NAME): Rename to...
> (lm_name): New function name.
> (IGNORE_FIRST_LINK_MAP_ENTRY): Rename to...
> (ignore_first_link_map_entry): New function name.
> (svr4_keep_data_in_core): Adapt to function name changes above.
> (svr4_current_sos): Likewise.
> (enable_break): Likewise.
> (svr4_relocate_section_addresses): Likewise.
Okay.
--
Pedro Alves