This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] h8300 target breakpoint doesn't work on Simulator
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org, Yoshinori Sato <ysato at users dot sourceforge dot jp>
- Date: Sat, 5 Mar 2011 07:26:32 +0400
- Subject: Re: [PATCH] h8300 target breakpoint doesn't work on Simulator
- References: <877hcen8ml.wl%ysato@users.sourceforge.jp> <201103041610.12924.vapier@gentoo.org>
> > - /*static unsigned char breakpoint[] = { 0x7A, 0xFF }; *//* ??? */
> > - static unsigned char breakpoint[] = { 0x01, 0x80 }; /* Sleep */
> > + static unsigned char breakpoint[] = { 0x7A, 0xFF }; /* bpt (only
> > simulator) */
>
> this sounds like you're fixing one system (sim) at the cost of
> breaking others (everyone else). this func is used by all h8300
> targets ... not just sim. so are you sure this is what you want ?
>
> try looking at the Blackfin tdep to see how we handle sim-specific bp's.
I was going to say exactly the very same thing.
--
Joel