This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] python/py-utils.c, delete unused variable (?)
- From: Michael Snyder <msnyder at vmware dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: Doug Evans <dje at google dot com>, "tromey at redhat dot com" <tromey at redhat dot com>
- Date: Mon, 28 Feb 2011 17:10:44 -0800
- Subject: Re: [RFA] python/py-utils.c, delete unused variable (?)
- References: <4D6C476E.3050505@vmware.com>
Michael Snyder wrote:
This LOOKS like an unused function call, but I have no idea
whether the function has side effects.
Tom? Doug?
Err, guess I should show you what I'm talking about...
2011-02-28 Michael Snyder <msnyder@vmware.com>
* python/py-utils.c (gdbpy_obj_to_string): Delete unused variable.
Index: python/py-utils.c
===================================================================
RCS file: /cvs/src/src/gdb/python/py-utils.c,v
retrieving revision 1.9
diff -u -p -u -p -r1.9 py-utils.c
--- python/py-utils.c 26 Jan 2011 20:53:45 -0000 1.9
+++ python/py-utils.c 1 Mar 2011 01:07:52 -0000
@@ -253,7 +253,6 @@ gdbpy_obj_to_string (PyObject *obj)
char *
gdbpy_exception_to_string (PyObject *ptype, PyObject *pvalue)
{
- PyObject *str_obj = PyObject_Str (pvalue);
char *str;
/* There are a few cases to consider.