This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] fix memory leak in gdbserver/server.c/handle_v_run
- From: Michael Snyder <msnyder at vmware dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: "drow at false dot org" <drow at false dot org>, Doug Evans <dje at google dot com>
- Date: Sat, 26 Feb 2011 16:40:36 -0800
- Subject: [RFA] fix memory leak in gdbserver/server.c/handle_v_run
Found by coverity.
2011-02-26 Michael Snyder <msnyder@vmware.com>
* server.c (handle_v_run): Free alloced buffer on early return.
Index: server.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
retrieving revision 1.139
diff -u -p -u -p -r1.139 server.c
--- server.c 14 Feb 2011 11:13:12 -0000 1.139
+++ server.c 27 Feb 2011 00:38:26 -0000
@@ -1949,16 +1949,16 @@ handle_v_run (char *own_buf)
if (program_argv == NULL)
{
- /* FIXME: new_argv memory leak */
write_enn (own_buf);
+ freeargv (new_argv);
return 0;
}
new_argv[0] = strdup (program_argv[0]);
if (new_argv[0] == NULL)
{
- /* FIXME: new_argv memory leak */
write_enn (own_buf);
+ freeargv (new_argv);
return 0;
}
}