This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] Avoid shadowing a function parameter in i387_supply_xsave
- From: Michael Snyder <msnyder at vmware dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Sat, 26 Feb 2011 15:44:23 -0800
- Subject: [commit] Avoid shadowing a function parameter in i387_supply_xsave
2011-02-26 Michael Snyder <msnyder@vmware.com>
* i387-tdep.c (i387_supply_xsave): Avoid shadowing a function
param with a local variable of the same name.
Index: i387-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/i387-tdep.c,v
retrieving revision 1.66
diff -u -p -u -p -r1.66 i387-tdep.c
--- i387-tdep.c 9 Jan 2011 03:08:56 -0000 1.66
+++ i387-tdep.c 26 Feb 2011 23:41:19 -0000
@@ -882,9 +882,9 @@ i387_supply_xsave (struct regcache *regc
if (val[0] & (1 << fpreg))
{
- int regnum = (fpreg + 8 - top) % 8
+ int thisreg = (fpreg + 8 - top) % 8
+ I387_ST0_REGNUM (tdep);
- tag = i387_tag (FXSAVE_ADDR (tdep, regs, regnum));
+ tag = i387_tag (FXSAVE_ADDR (tdep, regs, thisreg));
}
else
tag = 3; /* Empty */