This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Thu, Feb 17, 2011 at 16:16, Hui Zhu <teawater@gmail.com> wrote: > On Sat, Feb 12, 2011 at 05:31, Tom Tromey <tromey@redhat.com> wrote: >>>>>>> ">" == Hui Zhu <teawater@gmail.com> writes: >> >>>> To make the gdbserver support %s. >> >> Oops, I missed this when reviewing your earlier patch. >> Sorry about that. >> >>>> +int >>>> +tp_printf(const char *format, ...) >> >> Space before open paren. >> >>>> + ?va_end(ap); >> >> Likewise. >> >>>> + ? ? ? ?argv = (void *)(unsigned long)top; >> >> Spacing. >> >> There are several more spacing bugs, please fix them all. >> >> I didn't go read the other patch to try to deduce the format of the >> printf opcode to see if it all makes sense. ?Documentation would help. >> >> Tom >> > > Hi Tom, > > I make a new patch according to your comments. > > Thanks, > Hui > > 2011-02-17 ?Hui Zhu ?<teawater@gmail.com> > > ? ? ? ?* tracepoint.c (gdb_agent_op): Add gdb_agent_op_printf. > ? ? ? ?(gdb_agent_op_names): Add "printf". > ? ? ? ?(tp_printf): New function. > ? ? ? ?(eval_agent_expr): Handle gdb_agent_op_printf. > Checked in. Thanks, Hui 2011-02-21 Hui Zhu <teawater@gmail.com> * tracepoint.c (tp_printf): New function. (eval_agent_expr): Handle gdb_agent_op_printf.
Attachment:
tp_print_server.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |