This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Move common macros to i386-common.h


On 02/13/2011 09:40 PM, Mark Kettenis wrote:
> I'm just back from a 3+-week holiday.  I'm not buying into the "share more
> stuff between gdb and gdbserver" mantra yet.  Please hold off on this
> until
> I've gotten caught up with my mail and had a chance to think about all this.
> 
OK, no problem.  IMO, it is beneficial to source code maintenance.

w.r.t this specific patch, its "potential benefit" is that, some
duplicated functions (i386_length_and_rw_bits, and
i386_{insert|remove}_aligned_watchpoint) in i386-nat.c and
gdbserver/i386-low.c can be merged together.  Please take this into account.

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]