This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Add tests for JIT debugging interface

From: Pedro Alves <pedro at codesourcery dot com>
To: gdb-patches at sourceware dot org
Cc: Paul Pluzhnikov <ppluzhnikov at google dot com>, Yao Qi <yao at codesourcery dot com>
Date: Wed, 19 Jan 2011 13:49:16 -0700
Subject: Re: [patch] Add tests for JIT debugging interface
References: <20110111232641.AE3D5190C55@elbrus2.mtv.corp.google.com> <201101191203.35101.pedro@codesourcery.com> <AANLkTi=rBc_piQtpJ5uUO4ObaMGn=PKq3L8LmUnU+fHs@mail.gmail.com>

On Wednesday 19 January 2011 12:26:34, Paul Pluzhnikov wrote:
> On Wed, Jan 19, 2011 at 11:03 AM, Pedro Alves <pedro@codesourcery.com> 

> > It's output from infrun.c:normal_stop.  Sounds like a bug somewhere.
> 
> It is a bug. Fix in progress...
> 
> >> That's alright -- I was going to fix this area (see "JIT interface
> >> slowness" in gdb@sourceware.org list), and this isn't the only problem
> >> -- I also noticed that we leak several jit_breakpoints on rerun.
> 
> That leak is in fact causing the bug above ...

Ah.

Patch is okay.  As general principle, I'd rather fix the leak first and
avoid introducing new failures against gdbserver if possible and
easy, but if you want to check this in already, that'll  be okay too.

-- 
Pedro Alves

Follow-Ups:
- Re: [patch] Add tests for JIT debugging interface
  - From: Paul Pluzhnikov

References:
- [patch] Add tests for JIT debugging interface
  - From: Paul Pluzhnikov
- Re: [patch] Add tests for JIT debugging interface
  - From: Pedro Alves
- Re: [patch] Add tests for JIT debugging interface
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]