This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC-v2] Fix hpux_major_release variable setting
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: msnyder at vmware dot com
- Cc: pierre dot muller at ics-cnrs dot unistra dot fr, pedro at codesourcery dot com, gdb-patches at sourceware dot org, brobecker at adacore dot com
- Date: Sat, 15 Jan 2011 12:23:18 +0100 (CET)
- Subject: Re: [RFC-v2] Fix hpux_major_release variable setting
- References: <000f01cbb401$1093cdc0$31bb6940$@muller@ics-cnrs.unistra.fr> <20110114163035.GQ2504@adacore.com> <000001cbb40b$b03b3020$10b19060$@muller@ics-cnrs.unistra.fr> <201101141757.53748.pedro@codesourcery.com> <000301cbb41a$c115c590$434150b0$@muller@ics-cnrs.unistra.fr> <4D309B82.7070104@vmware.com>
> Date: Fri, 14 Jan 2011 10:52:50 -0800
> From: Michael Snyder <msnyder@vmware.com>
>
> Pierre Muller wrote:
> > Thanks for the feedback to
> > Pedro and Joel.
> >
> > Committed with void added.
> >
> > Pierre
> >
> > PS: The nit by Joel was a problem when I sent the patch,
> > there are no 4 empty lines, but
> > there is a "^L" line, which got lost
> > by the way I sent the patch in.
>
> Does it make sense to remove these ^L characters?
> I doubt if anybody prints out these sources any more...
To me they serve as logical markers to seperate sections of code. I
believe the GNU coding standards already mention that they're meant
for that purpose only and not meant for printing source code at all.
Using them has always been a matter of taste; I don't see a good
reason for going through the code to eliminate them.