[PATCH, V850] Add support for V850E2 and V850E2V3

[Rathish C <Rathish dot C at kpitcummins dot com>]

Hi,

Thank you for the review comments.

I have updated the patch based on the review comments from Kevin Buettner.

Please find the updated patch "v850-gdb-v850e2-v850e2v3-support.patch".

>
> Your changes to gdb/v850-tdep.c are approved.
>

Thank you for approving the changes to the gdb/v850-tdep.c file.

> 
> I have one comment (see below) for the sim portion of the patch.  The
> rest of the patch looks reasonable to me.  (It's unclear to me whether or
> not I can approve sim patches...)
>
>
>
>> diff -upNr gdb-7.2.50-original/sim/v850/sim-main.h gdb-7.2.50-
>> modified/sim/v850/sim-main.h
>> --- gdb-7.2.50-original/sim/v850/sim-main.h	2002-11-30 
>> 23:31:30.000000000 +0530
>> +++ gdb-7.2.50-modified/sim/v850/sim-main.h	2010-12-08 
>> 14:52:40.000000000 +0530 [...]
>> @@ -61,6 +65,7 @@ struct sim_state {
>>  #define STATE_CPU(sd,n) (&(sd)->cpu[n])
>>  #else
>>  #define STATE_CPU(sd,n) (&(sd)->cpu[0])
>> +#define CPU (STATE_CPU (sd, 0))
>>  #endif
>
>
> Do you really need to define CPU here?  It appears to me that a
> suitable definition for CPU is placed in support.h by igen at build
> time.  If it turns out that you do need this definition, you should
> make sure that the WITH_SMP case is handled too.
>


Yes, the CPU definition is available in support.h in the
./sim/v850/support.h file. 
I have removed the definition from the sim-main.h file and 
updated the patch accordingly.

Please review the patch and let me know if there should be 
any other modifications in it. 



2011-01-12  Rathish.C  <rathish.c@kpitcummins.com>
	
	* gdb/v850-tdep.c: Add the enum values for mpu and fpu registers
	(v850_register_name): Add the mpu and fpu register names.
	(v850e_register_name): Add the mpu and fpu register names.
	(v850e2_register_name): New function.
	(v850_gdbarch_init): Add case for bfd_mach_v850e2 and 
	bfd_mach_v850e2v3.
	* sim/common/sim-trace.c: Update the function prototype of 
	save_data_size.
	Move the enum data_fmt from here
	* sim/common/sim-trace.h: to here.
	Add function prototype of save_data
	* sim/v850/sim-main.h: Update the struct _v850_regs to include
	mpu and fpu system registers.
	Define the macros to access the mpu and fpu system registers.
	(SEXT3): Define.
	(TRACE_FP_INPUT_FPU1, TRACE_FP_INPUT_FPU2,
	TRACE_FP_INPUT_FPU3): Define.
	(TRACE_FP_INPUT_BOOL1_FPU2): Define.
	(TRACE_FP_INPUT_WORD2): Define.
	(TRACE_FP_RESULT_WORD1, TRACE_FP_RESULT_WORD2): Define.
	* sim/v850/simops.c: Update the function prototype of Add32
	(update_fpsr): New function.
	(SignalException): New function.
	(SignalExceptionFPE): New function.
	(check_invalid_snan): New function.
	(v850_float_compare): New function.
	(v850_div): New function.
	(v850_divu): New function.
	(v850_sar): New function.
	(v850_shl): New function.
	(v850_shr): New function.
	(v850_satadd): New function.
	(v850_satsub): New function.
	(load_data_mem): New function.
	(store_data_mem): New function.
	(mpu_load_mem_test): New function.
	(mpu_store_mem_test): New function.
	* sim/v850/simops.h: Add function prototype for above
	mentioned functions.
	(check_cvt_fi, check_cvt_if, check_cvt_ff): Define.
	* sim/v850/v850-dc: Add entry for v850e2 and v850e2v3.
	* sim/v850/v850.igen: Add support for v850e2 and v850e2v3

Thanks & Regards,
Rathish.C

Attachment: v850-gdb-v850e2-v850e2v3-support.patch
Description: v850-gdb-v850e2-v850e2v3-support.patch