Re: [patch] comment cleanup

[Michael Snyder <msnyder at vmware dot com>]

Joel Brobecker wrote:
> > 2010-12-28  Michael Snyder  <msnyder@vmware.com>
> >
> > 	* event-loop.c: Comment clean-up.
> > 	* event-loop.h: Ditto.
> > 	* event-top.c: Ditto.
> > 	* gdb.c: Ditto.
> > 	* gdb.h: Ditto.
> > 	* main.c: Ditto.
> > 	* top.c: Ditto.
> > 	* top.h: Ditto.	
>
> I just noticed that gdb.c contains unadvertized code updates :-),
> and this is causing the build to fail on platforms where mcheck.h
> is not available (Eg. ppc-aix).
>
> These have now been reverted with the following commit.

Ouch, sorry about that.  Thanks for catching it.

I had been using mtrace to look for memory leaks, and forgot to take it out.

> > Index: gdb.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/gdb.c,v
> > retrieving revision 1.9
> > diff -u -p -r1.9 gdb.c
> > --- gdb.c	14 May 2010 20:17:37 -0000	1.9
> > +++ gdb.c	29 Dec 2010 00:53:53 -0000
> > @@ -20,16 +20,21 @@
> >  #include "main.h"
> >  #include "gdb_string.h"
> >  #include "interps.h"
> > +#include <mcheck.h>
> >  
> >  int
> >  main (int argc, char **argv)
> >  {
> >    struct captured_main_args args;
> > +  int ret;
> >  
> > +  mtrace ();
> >    memset (&args, 0, sizeof args);
> >    args.argc = argc;
> >    args.argv = argv;
> >    args.use_windows = 0;
> >    args.interpreter_p = INTERP_CONSOLE;
> > -  return gdb_main (&args);
> > +  ret = gdb_main (&args);
> > +  muntrace();
> > +  return ret;