This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch, testsuite] General ARM target triplet
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 03 Dec 2010 17:35:52 +0000
- Subject: Re: [patch, testsuite] General ARM target triplet
- References: <4CF91BD4.7090708@codesourcery.com>
On Sat, 2010-12-04 at 00:33 +0800, Yao Qi wrote:
> diff --git a/gdb/testsuite/gdb.xml/tdesc-regs.exp
> b/gdb/testsuite/gdb.xml/tdesc-regs.exp
> index f37b2f3..64e56ea 100644
> --- a/gdb/testsuite/gdb.xml/tdesc-regs.exp
> +++ b/gdb/testsuite/gdb.xml/tdesc-regs.exp
> @@ -27,7 +27,7 @@ set core-regs ""
> set regdir ""
> set architecture ""
> switch -glob -- [istarget] {
> - "*arm-*-*" {
> + "*arm*-*-*" {
> set core-regs {arm-core.xml}
> }
> "xscale-*-*" {
So I think this is too broad. arm in the middle of a string could match
many things that are not ARM cores at all. I think the original code
dates back to support for StrongARM and someone was being lazy.
It's probably better to make this a specific test for strongarm* and
arm* rather than a very wide-ranging glob.
R.