Re: RFA: fix PR python/11792

[Eli Zaretskii <eliz at gnu dot org>]

> From: Tom Tromey <tromey@redhat.com>
> Cc: brobecker@adacore.com, gdb-patches@sourceware.org
> Date: Wed, 22 Sep 2010 13:50:55 -0600
> 
> Eli> Yes.  We are also supposed to humor the responsible maintainer when
> Eli> she asks for some simple change as part of the review process.
> 
> Tom> That is no reason to ignore the agreed-upon rules.
> 
> Eli> It is to me.  The agreed-upon rules are a two-way street, you know.
> 
> I don't see how your behavior helps the situation.

It is an expression of protest in the most quiet way I could come up
with.  If you'd just let it go, it would have stayed that way.

> Several alternatives to this approach were available to you.  For
> example, you could have sent email saying that it was not a suggestion.
> Or you could have said that in the first place.  Or, you could even have
> asked me to revert my patch.

None of these alternatives seemed better than what I did, given the
"do it yourself, if you want" response I got for my comments.

> Tom> In this case I did not read your message as a request.  I saw it as a
> Tom> conditional suggestion, which I chose not to take.
> 
> Eli> I don't see any difference between a suggestion and a request, when it
> Eli> comes from the responsible maintainer.
> 
> You once told me that you never vetoed a patch, and that "Disagreement,
> even a strong one, is not a veto unless you perceive it as such".  That
> is how I have read all email from you from then on -- I try to make the
> changes you like, but in the end, I rely on my own judgment.

Sorry, but you are abusing the intentionally soft tone of my review
comments and my urge to find a compromise almost at any cost.  I don't
veto patches, but I don't expect blunt refusal to do anything at all
about some of my comments, either.  I respect your judgment, but the
final approval of the patch is still my responsibility.  Until I say
"OK" or something to that effect, the discussion is not over and the
patch cannot go in asking me to do the rest if I want to.  These are
the rules, as far as I understand them; if I missed something, please
point out what that is.