This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 2/5] New patches to support --enable-targets=all for mingw64


>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre> 2010-09-10  Pierre Muller  <muller@ics.u-strasbg.fr>

Pierre> 	* alpha-mdebug-tdep.c (find_proc_desc): Cast SYMBOL_VALUE result to
Pierre> 	uintptr_t before cast to pointer to avoid warning.

I think it is better to use SYMBOL_VALUE_BYTES here.
See how this field is set in mdebugread.c:

	  e = ((struct mdebug_extra_func_info *)
	       obstack_alloc (&current_objfile->objfile_obstack,
			      sizeof (struct mdebug_extra_func_info)));
	  memset (e, 0, sizeof (struct mdebug_extra_func_info));
	  SYMBOL_VALUE_BYTES (s) = (gdb_byte *) e;

This is ok with that change.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]