This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Regression for gdb.stabs/gdb11479.exp [Re: [patch 1/2] Use custom hash function with bcache]
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: sami wagiaalla <swagiaal at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 1 Sep 2010 09:19:52 -0700
- Subject: Re: Regression for gdb.stabs/gdb11479.exp [Re: [patch 1/2] Use custom hash function with bcache]
- References: <4C6946E1.6000709@redhat.com> <AANLkTikH1rBzysO-nNT-w3a0me7zMcGfSpn7+7oJQdWk@mail.gmail.com> <AANLkTikbMcvP-+2iqZB3gP-gLcWY7B7r4t+HWtHK-a6f@mail.gmail.com> <4C6D5C83.3050602@redhat.com> <m3eidu2vt7.fsf@fleche.redhat.com> <4C756132.5050301@redhat.com> <20100901082539.GA24609@host1.dyn.jankratochvil.net>
> > 2010-08-25 Sami Wagiaalla <swagiaal@redhat.com>
> >
> > * psymtab.c (add_psymbol_to_bcache): Remove 'static' from
> > 'static partial_symbol psymbol'.
> > (psymbol_hash): New function.
> > (psymbol_compare): New function.
> > * bcache.c (hash_continue): New.
> > (hash): Use hash_continue.
> > * bcache.c: Add hash_function and compare_function
> > pointers to bcache struct.
> > (bcache_full): Use bcache->hash_function, and
> > bcache->compare_function.
> > (bcache_compare): New function.
> > (bcache_xmalloc): Take hash_function and
> > compare_function arguments and initialize the
> > bcach's pointers.
> > Updated comment.
> > * objfiles.c (allocate_objfile): Updated.
> > * symfile.c (reread_symbols): Updated.
>
> fb846e72510040325bffd8f755180ea0025108dc
> http://sourceware.org/ml/gdb-cvs/2010-08/msg00197.html
>
> It has a regression for gdb.stabs/gdb11479.exp on all the tested distros
> {x86_64,x86_64-m32,i686}-fedora{12,13,14snapshot}-linux-gnu even without
> -lmcheck.
Just so we don't duplicate efforts, I've have been looking into this.
I'm not completely done, yet, but I've found something suspicious.
For me, it causes a crash in gdb.ada/complete.exp:
(gdb) b 7
Breakpoint 1 at 0x401f96: file /[...]/foo.adb, line 7.
(gdb) run
Starting program: /[...]/foo
Breakpoint 1, foo () at /[...]/foo.adb:7
7 My_Global_Variable := Some_Local_Variable + 1; -- START
(gdb) complete p my_glob
[1] 22302 segmentation fault ../../../gdb foo
--
Joel