This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 1/3] Change cplus_specific to an alocated struct
- From: Tom Tromey <tromey at redhat dot com>
- To: sami wagiaalla <swagiaal at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 13 Jul 2010 11:16:01 -0600
- Subject: Re: [patch 1/3] Change cplus_specific to an alocated struct
- References: <4BFD4230.3030600@redhat.com> <m34ohdlap4.fsf@fleche.redhat.com> <4C167FCA.7030300@redhat.com> <m3pqzrucpg.fsf@fleche.redhat.com> <4C3B5907.2080200@redhat.com>
>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:
Sami> This patch cplus_specific is renamed to mangled_lang
Sami> - struct cplus_specific
Sami> + struct mangled_lang
I'm not super fond of this name, but I don't have a better suggestion.
Please add a new comment above the "struct" line that describes the
purpose of the struct.
Sami> {
Sami> /* This is in fact used for C++, Java, and Objective C. */
Sami> char *demangled_name;
Please rewrite this comment to describe the meaning of this field.
This is ok with those changes.
Tom