This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 1/3] Change cplus_specific to an alocated struct


>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:

Sami> This patch cplus_specific is renamed to mangled_lang

Sami> -    struct cplus_specific
Sami> +    struct mangled_lang

I'm not super fond of this name, but I don't have a better suggestion.

Please add a new comment above the "struct" line that describes the
purpose of the struct.

Sami>      {
Sami>        /* This is in fact used for C++, Java, and Objective C.  */
Sami>        char *demangled_name;

Please rewrite this comment to describe the meaning of this field.

This is ok with those changes. 

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]