This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA]dwarf reader: Avoid complaint on const type
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>, 'Doug Evans' <dje at google dot com>, gdb-patches at sourceware dot org
- Date: Thu, 1 Jul 2010 10:12:56 -0700
- Subject: Re: [RFA]dwarf reader: Avoid complaint on const type
- References: <41597.7287375883$1274454923@news.gmane.org> <AANLkTinrrd1jraPF95BXqQpKMke-s30gRnLBNspl3kMB@mail.gmail.com> <002401cb178c$57428a70$05c79f50$@muller@ics-cnrs.unistra.fr> <201007011808.55025.pedro@codesourcery.com>
> I hope you're not waiting for me to review this. (Honestly, in cases
> like these, I prefer to simply revert the original broken patch, and
> then calmly build a new correct patch from scratch. It becomes
> much easier to see and understand what was being addressed originaly
> instead of having to look at the code in 3D. I've noticed that
> people here have revert fobia though ;-) ).
Agreed on both counts - we should not be reluctant to revert.
--
Joel