This is the mail archive of the
mailing list for the GDB project.
Re: [patch 1/2] Search typedefs in namespaces also in other files
>>>>> "Jan" == Jan Kratochvil <firstname.lastname@example.org> writes:
Tom> I think you should leave that comment in the previous function and write
Tom> a new comment for lookup_static_symbol_aux.
Jan> Made some change. I find "comment in the previous function"
Jan> describes internals (="Do the symtabs first, then check the
Jan> psymtabs.") of the function being called. Such comment should not
Jan> be at the caller, should be?
I don't totally follow, but I suppose the ideal is for a comment to
describe what the function does and also relevant info about its
arguments and returns; and not describe exactly how the function may do
I think what you did here is fine.