This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [RFA 2/3] Import vsnprintf from libiberty if not available.


Nevermind, 
I finally found the answer myself,
by looking more deeply into gdbserver/configure

  The inclusion already works for memmem.o
by adding memmem.o to LIBOBJS around line 3812
  but that part did not need any change (as it use already $ac_func)
where the lines just before were changed by
your patch because they used MEMMEM/memmem explicitly
instead of $ac_xxx variables.

  As LIBOBJS didn't appear at all in your patch,
I had a hard time find out how the objects
are added to the needed list!


Pierre


> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pierre Muller
> Envoyé?: Thursday, June 24, 2010 2:08 PM
> À?: 'Joel Brobecker'; gdb-patches@sourceware.org
> Objet?: RE: [RFA 2/3] Import vsnprintf from libiberty if not available.
> 
>   Hi Joel,
> 
> 
>   I am probably missing a part of your patch...
> 
>   I do not understand what triggers the compilation of the
> vasprint.o and vsnprintf.o objects are added to the list
> of required objects to compile and link for the final
> gdbserver executable.
> 
>   I also saw not explicit reference to these objects
> in the third part of your patch.
> 
>   Is this inclusion hidden somewhere in your configure changes?
> 
> 
> Pierre Muller
> Pascal language support maintainer for GDB
> 
> 



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]