This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] display names of explicit typedefs for 'info types'


Pierre Muller wrote:
I was always puzzled by the fact that info types
did sometime not list types that I knew existed.
The problem is that for types defined in C using `typedef '
only the definition part was displayed, but not the name of the type itself.


  This small patch fixes that 'mis-feature'...
I was expecting lots of failures in the testsuite,
but was surprised to find no change that I could relate to the patch...

The following tiny example:
Start
typedef volatile int volint;
typedef int myint;

volint vol;
myint my;

int
main ()
{
  vol = 5;
  my = 8;
  return 0;
}
End

gives currently (compiled with stabs debug info) typedef int; (Repeated twice) typedef volatile int;

With the patch, I get:
typedef int;
typedef int myint;
typedef volatile int volint;

Note that the output of 'info var' is not really consistent:
(gdb) info var
myint my;
volatile int vol;
but this is not changed by my patch, and is the same as before..
(gdb) ptype my
type = int
Here again, the original typedef name is completely lost ...

Comments welcome,

Pierre Muller
Pascal language support maintainer for GDB

I think it's an incremental improvement.



2010-06-22 Pierre Muller <muller@ics.u-strasbg.fr>


        * c-typeprint.c (c_print_typedef): Append new type name for
typedefs.

Index: src/gdb/c-typeprint.c
===================================================================
RCS file: /cvs/src/src/gdb/c-typeprint.c,v
retrieving revision 1.58
diff -u -p -r1.58 c-typeprint.c
--- src/gdb/c-typeprint.c       21 Jun 2010 18:01:50 -0000      1.58
+++ src/gdb/c-typeprint.c       22 Jun 2010 22:36:06 -0000
@@ -107,7 +107,8 @@ c_print_typedef (struct type *type, stru
   type_print (type, "", stream, 0);
   if (TYPE_NAME ((SYMBOL_TYPE (new_symbol))) == 0
       || strcmp (TYPE_NAME ((SYMBOL_TYPE (new_symbol))),
-                SYMBOL_LINKAGE_NAME (new_symbol)) != 0)
+                SYMBOL_LINKAGE_NAME (new_symbol)) != 0
+      || TYPE_CODE (SYMBOL_TYPE (new_symbol)) == TYPE_CODE_TYPEDEF)
     fprintf_filtered (stream, " %s", SYMBOL_PRINT_NAME (new_symbol));
   fprintf_filtered (stream, ";\n");
 }



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]