This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 2/2] DW_OP_call: Support DW_OP_call2 and DW_OP_call4

>>>>> "Jan" == Jan Kratochvil <> writes:

Jan> 	Fix PR 10640.

Would you mind filing a new PR for DW_OP_call_ref?
This is one of the few remaining unimplemented operators...

Jan> +struct dwarf2_locexpr_baton
Jan> +fetch_die_location_block (unsigned int offset, struct dwarf2_per_cu_data *per_cu)

I think this function name should have a dwarf2_ prefix.
Also it looks like this line wraps.

Jan> --- a/gdb/symfile.h
Jan> +++ b/gdb/symfile.h
Jan> @@ -569,6 +569,10 @@ extern int dwarf2_has_info (struct objfile *);
Jan>  extern void dwarf2_build_psymtabs (struct objfile *);
Jan>  extern void dwarf2_build_frame_info (struct objfile *);
Jan> +struct dwarf2_per_cu_data;
Jan> +extern struct dwarf2_locexpr_baton fetch_die_location_block
Jan> +  (unsigned int offset, struct dwarf2_per_cu_data *per_cu);

I think this should go in one of the dwarf headers, not symfile.h.
I think probably dwarf2loc.h, near the other functions taking a

Ok with these changes.  Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]