This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] Fix PR bootstrap/42798
Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes:
> * Ian Lance Taylor wrote on Sun, Jun 06, 2010 at 11:42:13PM CEST:
>> My question about a basename declaration in the system header was a
>> genuine question. My concern is that on some systems this patch might
>> decide incorrectly whether or not basename is defined, which could
>> then possibly lead to a compilation error when libiberty.h is
> This concern should be addressed with my reply
> In short, the Autoconf change is designed to handle exactly this case
> right both in C and in C++ mode.
That doesn't really address my concern. That shows that autoconf will
get a workable answer if I use only C++. But there is only one
config.h file. gold has both .c and .cc files (the .c files are used
via AC_REPLACE_FUNCS). It's not obvious to me that a version of
HAVE_DECL_BASENAME for C++ will necessarily work when compiling C.