This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA] windows-nat.c: Copy console information for new console
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <gdb-patches at sourceware dot org>
- Date: Fri, 28 May 2010 12:16:59 +0200
- Subject: RE: [RFA] windows-nat.c: Copy console information for new console
- References: <001901caf934$fd580460$f8080d20$@muller@ics-cnrs.unistra.fr> <20100525205241.GA5298@ednor.casa.cgf.cx> <000601cafca7$ead3af80$c07b0e80$@muller@ics-cnrs.unistra.fr> <20100526170712.GA32594@ednor.casa.cgf.cx> <001801cafd69$018b9a00$04a2ce00$@muller@ics-cnrs.unistra.fr> <001e01cafd6c$2a0c87c0$7e259740$@muller@ics-cnrs.unistra.fr> <20100527151730.GA483@ednor.casa.cgf.cx>
> >> From Christopher Faylor
> >> I actually thought fairly carefully about flags. If you have a
> >> function
> >> which controls console info, then the function should set the flags
> >> appropriately to deal with the console info.
> >
> >
> > As you prefer,
> >here is a new version that also takes DWORD *flags as parameter.
> > I also tried to explain a little bit better
> >what the function tries to do.
>
> Thanks. Looks good. I forgot to say: Thanks for doing this. It
> looks like
> a nice improvement.
Hi Christopher,
does this mean that you want to test it
a little bit more before you give some more detailed
review or should I understand this as an approval?
Pierre