This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] windows-nat.c: Copy console information for new console
- From: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
- To: gdb-patches at sourceware dot org, Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Date: Thu, 27 May 2010 11:17:30 -0400
- Subject: Re: [RFA] windows-nat.c: Copy console information for new console
- References: <001901caf934$fd580460$f8080d20$@muller@ics-cnrs.unistra.fr> <20100525205241.GA5298@ednor.casa.cgf.cx> <000601cafca7$ead3af80$c07b0e80$@muller@ics-cnrs.unistra.fr> <20100526170712.GA32594@ednor.casa.cgf.cx> <001801cafd69$018b9a00$04a2ce00$@muller@ics-cnrs.unistra.fr> <001e01cafd6c$2a0c87c0$7e259740$@muller@ics-cnrs.unistra.fr>
On Thu, May 27, 2010 at 09:13:53AM +0200, Pierre Muller wrote:
> Please disregard the patch in the previous email,
>it contains an error that generates a compilation failure,
>sorry about this.
>
>> From Christopher Faylor
>> I actually thought fairly carefully about flags. If you have a
>> function
>> which controls console info, then the function should set the flags
>> appropriately to deal with the console info.
>
>
> As you prefer,
>here is a new version that also takes DWORD *flags as parameter.
> I also tried to explain a little bit better
>what the function tries to do.
Thanks. Looks good. I forgot to say: Thanks for doing this. It looks like
a nice improvement.
cgf