This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: fix bug in pieced value with offset
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 13 May 2010 14:39:09 -0600
- Subject: Re: RFC: fix bug in pieced value with offset
- References: <m3hbmbviko.fsf@fleche.redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
Tom> I plan to check this in. I would appreciate comments, though; I think I
Tom> got the big-endian stuff right, but I am having trouble thinking about
Tom> it very clearly, and I also had trouble creating a test case that might
Tom> show the difficulties.
I also belatedly realized a second problem:
Tom> for (i = 0; i < c->n_pieces; i++)
Tom> {
I think this loop needs an additional condition to avoid overwriting the
destination buffer. I'm testing an updated patch; don't let this stop
you from commenting on the rest of it, though :-)
Tom