This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: fix bug in pieced value with offset


>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> I plan to check this in.  I would appreciate comments, though; I think I
Tom> got the big-endian stuff right, but I am having trouble thinking about
Tom> it very clearly, and I also had trouble creating a test case that might
Tom> show the difficulties.

I also belatedly realized a second problem:

Tom>    for (i = 0; i < c->n_pieces; i++)
Tom>      {

I think this loop needs an additional condition to avoid overwriting the
destination buffer.  I'm testing an updated patch; don't let this stop
you from commenting on the rest of it, though :-)

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]